fix envoy-filter-example build breakage#95
Closed
Mythra wants to merge 1 commit intoenvoyproxy:masterfrom
Mythra:fix-build
Closed
fix envoy-filter-example build breakage#95Mythra wants to merge 1 commit intoenvoyproxy:masterfrom Mythra:fix-build
Mythra wants to merge 1 commit intoenvoyproxy:masterfrom
Mythra:fix-build
Conversation
the way of importing envoy dependencies is now different, this fixes them as well as includes the changes in: #94 (which added functionality but did not fix the build). Signed-off-by: Cynthia Coan <ccoan@instructure.com>
zuercher
reviewed
Jul 26, 2019
| rules_override = { | ||
| "py_proto_library": "@envoy_api//bazel:api_build_system.bzl", | ||
| }, | ||
| ) |
Member
There was a problem hiding this comment.
Is switched_rules_by_language necessary here? Seems like that should happen in envoy_dependencies.
Member
Author
There was a problem hiding this comment.
According to @kyessenov this is necessary:
His original comment states:
How do we update envoy-filter-example repo in lock-step? I need to update the WORKSPACE, since I can't load googleapis rules in the existing bazel/repositories.bzl (since it loads the googleapis).```
The PR that caused this break has a lot of context as to why it may be hard to reorder.
Member
|
Do you mind add a line to https://github.com/envoyproxy/envoy/blob/14c5371/ci/build_setup.sh#L75 so we don't have to manually open PR like this in the future? |
Member
Author
|
@lizan sure, lemme open that as a PR now. |
Mythra
pushed a commit
to Mythra/envoy
that referenced
this pull request
Jul 26, 2019
this forces the same workspace file we use for tests: - https://github.com/envoyproxy/envoy/blob/14c5371/ci/build_setup.sh#L75 to be pushed to the envoy-filter-example. this will allow not having to file a manual PR to fix the build, such as: - envoyproxy/envoy-filter-example#95 Signed-off-by: Cynthia Coan <ccoan@instructure.com>
Member
Author
|
envoyproxy/envoy#7737 has been opened. I'm going to close this since 7737 will replicate these changes over when it is merged. |
lizan
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jul 26, 2019
Description: this forces the same workspace file we use for tests: https://github.com/envoyproxy/envoy/blob/14c5371/ci/build_setup.sh#L75 to be pushed to the envoy-filter-example. this will allow not having to file a manual PR to fix the build, such as: envoyproxy/envoy-filter-example#95 Risk Level: Low Testing: locally Docs Changes: None Release Notes: None Signed-off-by: Cynthia Coan <ccoan@instructure.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the way of importing envoy dependencies is now different, this
fixes them as well as includes the changes in: #94 (which added
functionality but did not fix the build).